tools: require more trailing commas#46346
Merged
aduh95 merged 1 commit intonodejs:mainfrom Jan 25, 2023
Merged
Conversation
All of the import and export statements in the codebase already use trailing commas, this commit adds a linter rule to enforce that.
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
targos
approved these changes
Jan 25, 2023
panva
approved these changes
Jan 25, 2023
panva
added
author ready
RaisinTen
approved these changes
Jan 25, 2023
github-actions
bot
removed
the
request-ci
cjihrig
approved these changes
Jan 25, 2023
Contributor
Author
|
Landed in 4d4c1e5 |
ruyadorno
pushed a commit
that referenced
this pull request
Feb 1, 2023
All of the import and export statements in the codebase already use trailing commas, this commit adds a linter rule to enforce that. PR-URL: #46346 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Mar 3, 2023
All of the import and export statements in the codebase already use trailing commas, this commit adds a linter rule to enforce that. PR-URL: #46346 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Mar 3, 2023
All of the import and export statements in the codebase already use trailing commas, this commit adds a linter rule to enforce that. PR-URL: #46346 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
Mar 5, 2023
All of the import and export statements in the codebase already use trailing commas, this commit adds a linter rule to enforce that. PR-URL: #46346 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of the import and export statements in the codebase already use trailing commas, this commit adds a linter rule to enforce that.